Skip to content

Conversation

@dangotbanned
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@dangotbanned dangotbanned marked this pull request as ready for review March 27, 2025 21:08
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangotbanned ! I might have spotted one typo - aside that it looks great 👌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff 🎻🎻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok on a serious not, do you have any resource to learn this the right way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok on a serious not, do you have any resource to learn this the right way?

Haha I guess I'll take that as a compliment 😄

But I'm not sure I know what you mean @FBruzzesi - could you explain?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easiness with which you are able to introduce and combine typevar's and classes to make all the types coherent - I want to learn that 💡

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FBruzzesi ah that 😂

Well I suppose a lot of it is just putting in the time battling it out with mypy & pyright until things stick.

The most exhaustive resource would be the typing spec.
I use that whenever I come across a message/concept I'm not familiar with.

If you use VSCode, I strongly recommend enabling the inlay hints settings for Pylance.
When in doubt, you can just omit/delete an annotation and see what pyright has inferred it to be.
That usually helps nudge me towards solving an issue - if that doesn't match what I expected.

I'll try to have a think on it tomorrow if there's anything else I can share ☺️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlay hints

Now that I think about it, it must seem strange that I rarely annotate variables 😄

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's nice! just enabled it, thanks!

Co-authored-by: Francesco Bruzzesi <[email protected]>
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MarcoGorelli MarcoGorelli merged commit 3072d49 into main Mar 27, 2025
28 checks passed
@MarcoGorelli MarcoGorelli deleted the df-from-dict branch March 27, 2025 23:25
@dangotbanned
Copy link
Member Author

@MarcoGorelli @FBruzzesi thanks both for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants